events: fix race condition #10602
Merged
events: fix race condition #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
|
/cherry-pick version-2024.6 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10602 +/- ##
===========================================
- Coverage 92.51% 50.93% -41.59%
===========================================
Files 718 716 -2
Lines 35129 34877 -252
===========================================
- Hits 32499 17763 -14736
- Misses 2630 17114 +14484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
force-pushed
the
events/fix-race-condition
branch
from
42f4f8f to
7ab8d8f
Compare
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
force-pushed
the
events/fix-race-condition
branch
from
be7502b to
ec73ade
Compare
rissson
approved these changes
Jul 24, 2024
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ec73aded1a0613d5d2290b25f1b32a71f11aa75d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ec73aded1a0613d5d2290b25f1b32a71f11aa75d-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ec73aded1a0613d5d2290b25f1b32a71f11aa75dFor arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ec73aded1a0613d5d2290b25f1b32a71f11aa75d-arm64Afterwards, run the upgrade commands from the latest release notes. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
added a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fix race condition due to signal handlers not being scoped. before this PR, it was possible that a new request was started and signal handlers were connected while the old signal handlers were not disconnected yet, hence causing the data from the requests to be mixed together
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)